Vision revision and track#100
Conversation
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| def track_xyz( |
There was a problem hiding this comment.
There are some interesting parameters here, which probably need a bit more of an explanation of their ranges and their meaning. I see your doc string, but I think it needs more.
For all these:
- search_range: float = 10,
- memory: int = 1,
- adaptive_step: float = 0.5,
- adaptive_stop: float = 0.95,
There was a problem hiding this comment.
How big can each be? What are appropriate ranges?
There was a problem hiding this comment.
I took the doc from the original trackpy documentation.
There aren't appropriate ranges for these. They depend on the system size.
There was a problem hiding this comment.
So how does the user select what values to use?
There was a problem hiding this comment.
trial and error, based on the system they have. (concentration of particles, velocity of them, vibrations).
andrewtarzia
left a comment
andrewtarzia
left a comment
There was a problem hiding this comment.
Minor things, and changes in the Conversation comments, then all good
2 participants
Hi all @andrewtarzia @matteobecchi;
With this PR i solved:
get_soapdoesn't support theselectionoption. #99Then I:
dynsight.trackmodule, which now returnsTrj.I'm ready, whenever you want, for the revision.